Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider allowing empty version strings #6830

Closed
cwgoes opened this issue Jul 23, 2020 · 4 comments · Fixed by #6904 or #6909
Closed

Consider allowing empty version strings #6830

cwgoes opened this issue Jul 23, 2020 · 4 comments · Fixed by #6904 or #6909
Labels
good first issue help wanted
Milestone
IBC 1.0 [Implemen...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jul 23, 2020

The ICS specifications do not prohibit empty version strings for channels, but the SDK does - any reason why? Empty versions are safe, as long as they are agreed upon.
@cwgoes cwgoes added the x/ibc label Jul 23, 2020
@cwgoes cwgoes added this to the IBC 1.0 milestone Jul 23, 2020
@adizere adizere mentioned this issue Jul 23, 2020
Merged
6 tasks
@fedekunze
Copy link
Collaborator

ah, I didn't know they were valid. I guess I'm used to rejecting empty strings on the validation functions. We can change it 👍

@dauTT
Copy link
Contributor

dauTT commented Jul 29, 2020

Hi, can I work on this?

@fedekunze
Copy link
Collaborator

Thanks @dauTT. Ping me if you need any guidance

@dauTT dauTT mentioned this issue Jul 30, 2020
Merged
9 tasks
@mergify mergify bot closed this as completed in #6904 Jul 31, 2020
@dauTT
Copy link
Contributor

dauTT commented Jul 31, 2020 •
edited
Loading

We should re-open this issue, because we missed to remove this piece of code:

image

@dauTT dauTT mentioned this issue Aug 1, 2020
Merged
9 tasks
@cwgoes cwgoes reopened this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
IBC 1.0 [Implementation]
3 participants
@cwgoes @dauTT @fedekunze