Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for IBC to only use proto #6975

Closed
4 tasks
colin-axner opened this issue Aug 7, 2020 · 0 comments · Fixed by #7148
Closed
4 tasks

Enable support for IBC to only use proto #6975

colin-axner opened this issue Aug 7, 2020 · 0 comments · Fixed by #7148

Comments

@colin-axner
Copy link
Contributor

Summary

Simulations break if IBC enables a non-empty genesis. IBC 1.0 will not support amino nor have any reference to amino.

Problem Definition

Following the merge of #6974 localhost will not be created during simulations to allow for an empty genesis and avoid encoding panics during init genesis. I added a comment to why I think this is on the ibc-genesis migration pr.

My knowledge is a bit limited in this encoding area so I may have made incorrect deductions, but with the current implementation in IBC, simulations will not pass given a non-empty genesis. We added a unit test to replicate the functionality of import-export using a proto codec and this test passes (when given both empty and non-empty genesis), which leads me to assume this is entirely an amino issue.

Proposal

simapp should use proto, it can still support amino for legacy querier options, but we should be running genesis import export simulations with a proto codec.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant