You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Simulations break if IBC enables a non-empty genesis. IBC 1.0 will not support amino nor have any reference to amino.
Problem Definition
Following the merge of #6974 localhost will not be created during simulations to allow for an empty genesis and avoid encoding panics during init genesis. I added a comment to why I think this is on the ibc-genesis migration pr.
My knowledge is a bit limited in this encoding area so I may have made incorrect deductions, but with the current implementation in IBC, simulations will not pass given a non-empty genesis. We added a unit test to replicate the functionality of import-export using a proto codec and this test passes (when given both empty and non-empty genesis), which leads me to assume this is entirely an amino issue.
Proposal
simapp should use proto, it can still support amino for legacy querier options, but we should be running genesis import export simulations with a proto codec.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
Simulations break if IBC enables a non-empty genesis. IBC 1.0 will not support amino nor have any reference to amino.
Problem Definition
Following the merge of #6974 localhost will not be created during simulations to allow for an empty genesis and avoid encoding panics during init genesis. I added a comment to why I think this is on the ibc-genesis migration pr.
My knowledge is a bit limited in this encoding area so I may have made incorrect deductions, but with the current implementation in IBC, simulations will not pass given a non-empty genesis. We added a unit test to replicate the functionality of import-export using a proto codec and this test passes (when given both empty and non-empty genesis), which leads me to assume this is entirely an amino issue.
Proposal
simapp should use
proto
, it can still support amino for legacy querier options, but we should be running genesis import export simulations with a proto codec.For Admin Use
The text was updated successfully, but these errors were encountered: