Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handshake to match revised specification #7025

Closed
cwgoes opened this issue Aug 12, 2020 · 3 comments · Fixed by #7439
Closed

Update handshake to match revised specification #7025

cwgoes opened this issue Aug 12, 2020 · 3 comments · Fixed by #7439
Assignees
@colin-axner
Milestone
IBC 1.0 [Implemen...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Aug 12, 2020

Blocked on cosmos/ibc#462, cosmos/ibc#459
@cwgoes cwgoes added the x/ibc label Aug 12, 2020
@cwgoes cwgoes added this to the IBC 1.0 milestone Aug 12, 2020
@fedekunze fedekunze added the S:blocked Status: Blocked label Aug 20, 2020
@cwgoes cwgoes removed the S:blocked Status: Blocked label Sep 4, 2020
@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 4, 2020

This is now unblocked; the specification changes are in cosmos/ibc#479.

We'll need to make changes to connOpenTry and connOpenAck as outlined in that PR.

@cwgoes cwgoes assigned fedekunze and unassigned fedekunze Sep 8, 2020
@cwgoes cwgoes added the S:blocked Status: Blocked label Sep 8, 2020
@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 8, 2020

My mistake, still blocked on cosmos/ibc#462.

@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 15, 2020

The two changes from cosmos/ibc#462 & cosmos/ibc#459 can be split into separate PRs if you like @colin-axner.

@colin-axner colin-axner mentioned this issue Sep 16, 2020
Merged
9 tasks
This was referenced Oct 1, 2020
Merged
Closed
@cwgoes cwgoes removed the S:blocked Status: Blocked label Oct 1, 2020
@colin-axner colin-axner mentioned this issue Oct 2, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
None yet
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

Successfully merging a pull request may close this issue.

Flexible Channel Handshake Selection cosmos/cosmos-sdk
3 participants
@cwgoes @colin-axner @fedekunze