Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GetChainID from client state interface in 02-client exported #7143

Closed
4 tasks
colin-axner opened this issue Aug 24, 2020 · 0 comments · Fixed by #7219
Closed
4 tasks

remove GetChainID from client state interface in 02-client exported #7143

colin-axner opened this issue Aug 24, 2020 · 0 comments · Fixed by #7219
Assignees
@fedekunze
Labels
good first issue
Milestone
IBC 1.0 [Implemen...

Comments

@colin-axner
Copy link
Contributor

Summary

GetChainID is not being used and we should try to minimize the functions required for a client state.

Proposal

Remove GetChainID from ClientState in 02-client/exported/exported.go. The function can remain in the tendermint client state if necessary.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
good first issue
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

Successfully merging a pull request may close this issue.

ibc: remove GetChainID cosmos/cosmos-sdk
2 participants
@colin-axner @fedekunze