Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stargate gaiad should have the option to emit signed Amino encoded TX from the tx sign and tx multisign commands #7213

Closed
4 tasks
zmanian opened this issue Sep 1, 2020 · 1 comment · Fixed by #7221

Comments

@zmanian
Copy link
Member

zmanian commented Sep 1, 2020

In the Stargate version of the cosmos SDK, we accept signed AminoJSON encoded transactions via :1317/txs endpoint but there isn't an included tool to demonstrate what this JSON should look like.

I've prototyped a simple mechanism that uses a flag on tx sign and tx multisign to output AminoJSON encoded JSON instead of JSONEncoder() txs.

It's a pretty natural place for this and should help developers with porting.

Just asking for comments before making a PR.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

/cc @aaronc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants