Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secp256r1 Signing Keys #7718

Closed
4 tasks
aaronc opened this issue Oct 28, 2020 · 3 comments · Fixed by #8559
Closed
4 tasks

Add secp256r1 Signing Keys #7718

aaronc opened this issue Oct 28, 2020 · 3 comments · Fixed by #8559
Assignees
Labels
Milestone

Comments

@aaronc
Copy link
Member

aaronc commented Oct 28, 2020

Summary

Add support for singing tranactions with the secp256r1/NIST P-256 algorithm (used in macOS/iOS/watchOS & Android secure enclaves). Already discussed in #4789 and #7074 but there was no standalone issue.

Problem Definition

Supporting the signing algorithm for the secure enclave in macOS/iOS/watchOS and Android Hardware-backed Keystore will allow these devices to basically function as hardware wallets. There has been speculation that the secp256r1/NIST P-256 algorithm was backdoored by the NSA, but this is unproven and users should be able to choose their desired level of security. For many users, having a smartphone-backed key for low security operations (as enabled by the other key management modules #7074) may be the best options.

Proposal

  • add a secp256r1/NIST P-256 PubKey implementation with addresses based on ADR 028
  • add support to the ante handler with a proper gas param
  • DON'T add support in the keyring because this is for mobile/desktop clients ONLY

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@aaronc aaronc added the backlog label Oct 28, 2020
@aaronc aaronc added this to the v0.41 milestone Oct 28, 2020
@aaronc aaronc mentioned this issue Oct 28, 2020
4 tasks
@zmanian
Copy link
Member

zmanian commented Oct 29, 2020

Strong support.

@clevinson
Copy link
Contributor

@aaronc Is it possible that this gets put in a point release after the initial v0.42 is cut?

@aaronc
Copy link
Member Author

aaronc commented Jan 27, 2021

@aaronc Is it possible that this gets put in a point release after the initial v0.42 is cut?

Sure, but it would probably need to be 0.43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants