Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20-transfer: use special prefix for denominations #7906

Closed
cwgoes opened this issue Nov 12, 2020 · 2 comments · Fixed by #7926
Closed

20-transfer: use special prefix for denominations #7906

cwgoes opened this issue Nov 12, 2020 · 2 comments · Fixed by #7926
Assignees
Labels
T:Docs Changes and features related to documentation. T: Security

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Nov 12, 2020

Clarify that the IBC module needs a subset of the denomination space that only it can create tokens in, and use one.

@colin-axner
Copy link
Contributor

Does Clarify imply enforcing this via code or documenting it? We currently use ibc/ for cross chain token denom.

Enforcing via code sounds like injecting custom logic into bank or using capabilities. Are there any other potential solutions here?

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 12, 2020

Right. I guess it would require something like x/bank exporting special versions of MintCoins which could only mint coins for a particular prefixed subspace of coin denominations and giving the prefixed minter for ibc/ to the 20-transfer module, then prohibiting the / character in regular denominations. That's probably too large a refactor for now but we should at least document that 20-transfer requires this for safety even though it isn't enforced explicitly (just coincidentally not possible on the Hub).

@cwgoes cwgoes added the T:Docs Changes and features related to documentation. label Nov 12, 2020
@colin-axner colin-axner self-assigned this Nov 13, 2020
@mergify mergify bot closed this as completed in #7926 Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation. T: Security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants