Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move key presentation function outside of keyring #8046

Closed
4 tasks
robert-zaremba opened this issue Nov 30, 2020 · 4 comments
Closed
4 tasks

Move key presentation function outside of keyring #8046

robert-zaremba opened this issue Nov 30, 2020 · 4 comments
Labels
C:Keys Keybase, KMS and HSMs T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Nov 30, 2020

Summary

Bech32 Key presentation functions were added to a keyring package as a workaround for import cycle. Now we can remove it.

This is related to: #7447

Problem Definition

Keyring package is responsible for storing keys, not for client presentation. To stabilize

Proposal

  • Move presentation functions to the parent package.
  • Update client/keys/add.go:printCreate function

I already started a work for this while doing #7447


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba self-assigned this Nov 30, 2020
@robert-zaremba robert-zaremba added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Mar 11, 2021
@mergify mergify bot closed this as completed in #8854 Mar 12, 2021
@robert-zaremba
Copy link
Collaborator Author

Wrong reference. This should not be closed.

@amaury1093
Copy link
Contributor

@robert-zaremba Are you still working on this? @cyberbono3 would like to work on this, he'll ping you about it

@robert-zaremba
Copy link
Collaborator Author

no, never started it. this task is blocked by the keyring migration.

@robert-zaremba robert-zaremba removed their assignment Jul 14, 2021
@cyberbono3
Copy link
Contributor

I will start working on it after keyring-migration is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

No branches or pull requests

5 participants