Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract log flags in the SDK #8143

Closed
4 tasks
colin-axner opened this issue Dec 10, 2020 · 0 comments · Fixed by #8144
Closed
4 tasks

Abstract log flags in the SDK #8143

colin-axner opened this issue Dec 10, 2020 · 0 comments · Fixed by #8144
Assignees
Labels
C:CLI T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@colin-axner
Copy link
Contributor

Summary

While testing the latest commits on gaia, we ran into an issue where nothing occurred after running gaiad start. At first we thought gaia was hanging, but then we tracked down the issue to the log changes needing to be reflected in the gaia code. Specifically the log flags in #8072 needed to be updated in rootCmd#Execute

This should be abstracted and handled by the SDK, a lot of applications will likely run into the same issue as we did.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants