CLI gov deposit JSON errors with ledger

[fedekunze]

Summary of Bug

Deposit JSON can't be signed by ledger due to whitespace

Version

Gaia v4.2.0
Ledger Cosmos v2.18.0

Steps to Reproduce

gaiad tx gov deposit <proposal> <amount> <flags> --ledger

confirm transaction before signing and broadcasting [y/N]: y
Error: JSON Contains whitespace in the corpus

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[fedekunze]

also fails with gaiad tx sign <file>

[fedekunze]

cc @jleni

[amaury1093]

Where in the JSON are there whitespaces? Could you --generate-only to see the JSON?

[jleni]

same question. Could you post the payload you are sending?
if there is a bug, we should be able to reproduce it by adding an additional unit test to the parser

[fedekunze]

{"body":{"messages":[{"@type":"/cosmos.gov.v1beta1.MsgDeposit","proposal_id":"44","depositor":"cosmos1849m9wncrqp6v4tkss6a3j8uzvuv0cp7wcgvqa","amount":[{"denom":"uatom","amount":"255000000"}]}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[],"fee":{"amount":[{"denom":"uatom","amount":"54"}],"gas_limit":"106309","payer":"","granter":""}},"signatures":[]}

[amaury1093]

Ah, my bad, --generate-only doesn't print the SignDoc (the signing payload), just the proto JSON of the full tx.

I added manually a fmt.Println of the amino SignDoc while testing on a local chain (explicity with spaces in the memo), and it printed:

{"account_number":"8","sequence":"2","chain_id":"my-chain","memo":"A B C","fee":{"amount":[],"gas":"200000"},"msgs":[{"type":"cosmos-sdk/MsgDeposit","value":{"amount":[{"amount":"10","denom":"stake"}],"depositor":"cosmos1xl2256vdh0j68khz9wq88hnyqcq0f5f4za2480","proposal_id":"1"}}]}

which seems correct. I also managed to deposit, so I couldn't reproduce the initial error.

BTW, afaiu the --ledger flag is useless here, since the CLI read from the --from and determines if it's a ledger key or not from the keyring. That flag is used only in keys add command.

@fedekunze Could you provide more details about the reproduction steps?

[fedekunze]

ok this is super weird but this only fails if the amount is ≥ 100 atoms (100000000uatom)

[fedekunze]

prob a parsing issue?

[ftheirs]

Added test for parser and integration! This is working fine!
Related PR: cosmos/ledger-cosmos#77