Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: x/staking deterministic tests #13426

Merged
merged 33 commits into from
Oct 18, 2022
Merged

feat: x/staking deterministic tests #13426

merged 33 commits into from
Oct 18, 2022

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Sep 30, 2022

Description

Closes: #13193


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #13426 (30fc47c) into main (1f10efe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13426      +/-   ##
==========================================
+ Coverage   54.70%   54.71%   +0.01%     
==========================================
  Files         645      645              
  Lines       55691    55691              
==========================================
+ Hits        30465    30472       +7     
+ Misses      22737    22732       -5     
+ Partials     2489     2487       -2     
Impacted Files Coverage Δ
x/gov/keeper/msg_server.go 83.07% <100.00%> (ø)
x/staking/simulation/operations.go 75.91% <0.00%> (+1.37%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@atheeshp atheeshp marked this pull request as ready for review October 11, 2022 10:13
@atheeshp atheeshp requested a review from a team as a code owner October 11, 2022 10:13
@kocubinski kocubinski self-assigned this Oct 12, 2022
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, will have another round of review to check details

x/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
x/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
x/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
x/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
x/staking/keeper/determinstic_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending #13426 (comment)

@amaury1093 amaury1093 enabled auto-merge (squash) October 18, 2022 14:23
@atheeshp atheeshp enabled auto-merge (squash) October 18, 2022 16:36
@atheeshp atheeshp merged commit 49ad3b0 into main Oct 18, 2022
@atheeshp atheeshp deleted the ap/staking-regression-tests branch October 18, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write regression & test vectors for x/staking queries
4 participants