Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: set proper v0.47.x buf commit #15142

Merged
merged 1 commit into from
Feb 23, 2023
Merged

docs: set proper v0.47.x buf commit #15142

merged 1 commit into from
Feb 23, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 23, 2023 •
edited
Loading

Description

After the migration to CometBFT, due to the tendermint proto package changes, we needed to update the buf commit corresponding to v0.47.
This PR does that (ref #15119 (comment))

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner February 23, 2023 21:08
@tac0turtle tac0turtle merged commit 7d28f63 into main Feb 23, 2023
@tac0turtle tac0turtle deleted the julien/buf-commit branch February 23, 2023 21:17
@julienrbrt
Copy link
Member Author

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023 •
edited
Loading

backport release/v0.47.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 23, 2023
@julienrbrt @mergify
docs: set proper v0.47.x buf commit (#15142)
fa55c48 
(cherry picked from commit 7d28f63)

# Conflicts:
#	proto/README.md
@mergify mergify bot mentioned this pull request Feb 23, 2023
Merged
julienrbrt added a commit that referenced this pull request Feb 23, 2023
@mergify @julienrbrt
docs: set proper v0.47.x buf commit (backport #15142) (#15143)
b123507 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @tac0turtle