Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): extract (*Store).saveChunk method #15144

Merged
merged 2 commits into from
Feb 27, 2023

Commits on Feb 23, 2023

  1. refactor(store): extract (*Store).saveChunk method

    There was a valid, but ignored, linter warning about a deferred close in
    a loop. Extract a method so that the defer can exist in a more narrow
    function scope, instead of each defer accumulating as the channel is
    iterated.
    
    While here, only call os.MkdirAll once at the start, instead of
    repeatedly with the same arguments on every chunk encountered. Also
    distinguish the wrapped error message when closing the chunk file vs.
    the incoming chunk body.
    mark-rushakoff committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    e9f447d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Configuration menu
    Copy the full SHA
    199631a View commit details
    Browse the repository at this point in the history