test(x/gov): fix flaky TestActivateVotingPeriod test #15153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this fail on CI on an unrelated change. Upon investigation, the flaky failure occurred every time that the "expedited proposal" case ran before the "regular proposal" case, which happens fairly often due to randomized map iteration order. Changing the testCases value from a map to a slice to keep the order fixed, allows the test to pass consistently. I assume using a fixed ordering matches the original intent of the test.
julienrbrt
approved these changes
Feb 24, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed this fail on CI on an unrelated change. Upon investigation, the flaky failure occurred every time that the "expedited proposal" case ran before the "regular proposal" case, which happens fairly often due to randomized map iteration order.
Changing the testCases value from a map to a slice to keep the order fixed, allows the test to pass consistently. I assume using a fixed ordering matches the original intent of the test.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
provided a link to the relevant issue or specificationreviewed "Files changed" and left comments if necessaryReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...