chore: bump cometbft to v0.37.0-rc3 #15220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
the
backport/v0.47.x
github-actions
bot
added
C:CLI
C:Confix
|
Looks like there is something again with events... Checking. |
julienrbrt
commented
Mar 1, 2023
x/gov/client/utils/query.go
Outdated
| fmt.Sprintf("%s.%s='%d'", types.EventTypeProposalDeposit, types.AttributeKeyProposalID, params.ProposalID), | ||
| }, | ||
| ) | ||
| q := fmt.Sprintf("%s.%s='%d'", types.EventTypeProposalDeposit, types.AttributeKeyProposalID, params.ProposalID) |
There was a problem hiding this comment.
As explained by @jmalicevic, CometBFT changed its logic for indexing events.
Because we emit two different events (one containing the message action (from baseapp) and one containing these events keys) this was returning nothing. The new logic wants all the conditions to be valid in the same event.
I've checked that at no other place in the gov module these event keys were emitted with the same attributes in another message. We can then simplify the logic.
julienrbrt
commented
Mar 1, 2023
| @@ -378,28 +277,10 @@ func QueryDepositByTxQuery(clientCtx client.Context, params v1.QueryDepositParam | |||
| return nil, fmt.Errorf("address '%s' did not deposit to proposalID %d", params.Depositor, params.ProposalID) | |||
| } | |||
|
|
|||
| // QueryProposerByTxQuery will query for a proposer of a governance proposal by | |||
| // ID. | |||
| // QueryProposerByTxQuery will query for a proposer of a governance proposal by ID. | |||
| func QueryProposerByTxQuery(clientCtx client.Context, proposalID uint64) (Proposer, error) { | |||
There was a problem hiding this comment.
We could replace this one by a query in a follow-up, given that we store the proposer in the proposal.
tac0turtle
approved these changes
Mar 1, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
(cherry picked from commit 41c8529) # Conflicts: # .github/workflows/lint.yml # Makefile # client/v2/go.mod # client/v2/go.sum # collections/go.mod # go.mod # go.sum # log/go.mod # simapp/go.mod # store/go.mod # store/go.sum # tests/go.mod # tests/go.sum # tools/confix/go.mod # tools/confix/go.sum # tools/cosmovisor/go.mod # tools/cosmovisor/go.sum # tools/hubl/go.mod # tools/hubl/go.sum # tools/rosetta/go.mod # tools/rosetta/go.sum # x/auth/tx/query.go # x/circuit/go.mod # x/circuit/go.sum # x/evidence/go.mod # x/evidence/go.sum # x/feegrant/go.mod # x/feegrant/go.sum # x/gov/client/utils/query.go # x/gov/client/utils/query_test.go # x/nft/go.mod # x/nft/go.sum # x/upgrade/go.mod # x/upgrade/go.sum
julienrbrt
added a commit
that referenced
this pull request
Mar 1, 2023
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps to cometbft v0.37.0-rc3.
This will be backported to release/v0.47.x and we'll tag a v047 rc3.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change