-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve UGPRADING.md #15236
chore: improve UGPRADING.md #15236
Conversation
@@ -6,25 +6,26 @@ This guide provides instructions for upgrading to specific versions of Cosmos SD | |||
|
|||
### Migration to CometBFT (Part 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we combine the two migration to comet bft sections into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2 is unreleased and Part 1 is under v0.47, so I don't think so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i thought what is on main is also used in 0.47 so it seemed to be overlapping.
Oh these are items we changed in our repo. Kind of confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really follow. There were some thing repetitive from the other PR, but I've removed it here.
There is indeed some categories that are the same between unreleased and v0.47, but this is because we've changed more things after v0.47 had its scope fixed. So this is why it is under unreleased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was mainly confusing to see part 1 and part 2 but they are not in the same release and have two different scopes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can reword. As it was both related I thought it was clear. I am not sure how to name the "Part 2" otherwise, as I feel like it's still clearly related.
Co-authored-by: Marko <marbar3778@yahoo.com>
Description
Follow-up of #15211
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change