Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: x/feegrant audit changes #16652

Merged
merged 6 commits into from
Jun 23, 2023
Merged

chore: x/feegrant audit changes #16652

merged 6 commits into from
Jun 23, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jun 22, 2023

Description

ref: #16508


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review June 22, 2023 13:20
@atheeshp atheeshp requested a review from a team as a code owner June 22, 2023 13:20
@tac0turtle tac0turtle added this pull request to the merge queue Jun 23, 2023
Merged via the queue into main with commit d0b42dc Jun 23, 2023
@tac0turtle tac0turtle deleted the ap/audit-feegrant branch June 23, 2023 07:55
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think protos should have been re-generated.

@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2023

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 23, 2023
tac0turtle pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants