-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configurator config options #16672
Conversation
@julienrbrt your pull request is missing a changelog! |
Adding the backport label to v0.47 as well and I'll be backporting the two previous PRs about the configurator as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, we should get rid of this panic imo.
(cherry picked from commit dcc5afe)
(cherry picked from commit dcc5afe) # Conflicts: # testutil/configurator/configurator.go
Mmh, actually the assertion works as intended, I had a module which had an init genesis function defined, but wasn't specified in the OrderInitGenesis, so this is great it panics. The issue was: I couldn't simply add it in the configurator. |
Description
The more I use the configurator, the more I need it more configurable.
Currently you cannot use it when adding external modules, this PR solves that.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change