Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete all votes when proposal is cancelled #16824

Merged
merged 10 commits into from
Jul 5, 2023
Merged

fix: delete all votes when proposal is cancelled #16824

merged 10 commits into from
Jul 5, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #16162

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review July 4, 2023 11:33
@likhita-809 likhita-809 requested a review from a team as a code owner July 4, 2023 11:33
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@likhita-809 your pull request is missing a changelog!

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 4, 2023
julienrbrt
julienrbrt reviewed Jul 4, 2023
View reviewed changes
x/gov/keeper/proposal_test.go Show resolved Hide resolved
x/gov/keeper/proposal_test.go Show resolved Hide resolved
x/gov/keeper/proposal_test.go Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/gov/keeper/proposal_test.go Show resolved Hide resolved
testinginprod
testinginprod reviewed Jul 4, 2023
View reviewed changes
x/gov/keeper/vote.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, given we address @testinginprod's comment on using Clear.

likhita-809
likhita-809 commented Jul 5, 2023
View reviewed changes
tests/e2e/gov/tx.go Outdated Show resolved Hide resolved
atheeshp
atheeshp approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit.

x/gov/keeper/proposal_test.go Outdated Show resolved Hide resolved
testinginprod
testinginprod approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

x/gov/keeper/vote.go
@@ -58,6 +58,11 @@ func (keeper Keeper) AddVote(ctx context.Context, proposalID uint64, voterAddr s

// deleteVotes deletes the all votes from a given proposalID.
func (keeper Keeper) deleteVotes(ctx context.Context, proposalID uint64) error {
// TODO(tip): fix https://github.com/cosmos/cosmos-sdk/issues/16162
rng := collections.NewPrefixedPairRange[uint64, sdk.AccAddress](proposalID)
err := keeper.Votes.Clear(ctx, rng)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@julienrbrt julienrbrt added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit 9dcf870 Jul 5, 2023
@julienrbrt julienrbrt deleted the likhita/delete-cancelled-proposals-votes branch July 5, 2023 08:33
mergify bot pushed a commit that referenced this pull request Jul 5, 2023
@likhita-809 @mergify
fix: delete all votes when proposal is cancelled (#16824)
bb346ab 
(cherry picked from commit 9dcf870)
@mergify mergify bot mentioned this pull request Jul 5, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Jul 5, 2023
@mergify @likhita-809
fix: delete all votes when proposal is cancelled (backport #16824) (#…
565b1e9 
…16837)

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

@atheeshp atheeshp atheeshp approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: x/gov does not delete all votes when proposal is cancelled
5 participants
@likhita-809 @alexanderbez @julienrbrt @atheeshp @testinginprod