fix: testutil/configurator: correctly create fresh copy of defaultConfig #17089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a data race that was caused by incorrectly copying the defaultConfig, a pointer value and that "copied value" was passed around to independent tests yet they were all mutating the same value. The fix involves creating a true/correct fresh copy each time. Fixes #17081
julienrbrt
added
backport/v0.47.x
julienrbrt
approved these changes
Jul 22, 2023
julienrbrt
deleted the
testutil-configurator-create-fresh-config-instead-of-same-pointer-copy
branch
julienrbrt
pushed a commit
that referenced
this pull request
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a data race that was caused by incorrectly copying the defaultConfig, a pointer value and that "copied value" was passed around to independent tests yet they were all mutating the same value. The fix involves creating a true/correct fresh copy each time.
Fixes #17081