Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): Use ValidatorAddrCodec #17095

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

itsdevbear
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@itsdevbear itsdevbear requested a review from a team as a code owner July 23, 2023 19:56
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 23, 2023
@julienrbrt julienrbrt changed the title fix(x/staking): Use ValidatorAddrCodec refactor(x/staking): Use ValidatorAddrCodec Jul 23, 2023
@julienrbrt
Copy link
Member

julienrbrt commented Jul 23, 2023

That's a good one! I see it used at multiple other places in staking, would you mind going through staking and replace the usage everywhere applicable? Or open an issue so someone else can do it?
image

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can pick up the rest of the cleanup

@julienrbrt julienrbrt added this pull request to the merge queue Jul 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Jul 23, 2023
Merged via the queue into cosmos:main with commit bf9f85a Jul 23, 2023
mergify bot pushed a commit that referenced this pull request Jul 23, 2023
tac0turtle pushed a commit that referenced this pull request Jul 23, 2023
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants