Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ValidatorStore interface doesn't match StakingKeeper (backport #17164) #17283

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 3, 2023

This is an automatic backport of pull request #17164 done by Mergify.
Cherry-pick of c3ae0b0 has failed:

On branch mergify/bp/release/v0.50.x/pr-17164
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit c3ae0b09d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   baseapp/abci_test.go
	modified:   baseapp/abci_utils.go
	modified:   baseapp/testutil/mock/mocks.go
	modified:   docs/architecture/adr-064-abci-2.0.md
	new file:   tests/integration/staking/keeper/vote_extensions_test.go
	modified:   x/staking/keeper/validator.go
	modified:   x/staking/testutil/expected_keepers_mocks.go
	modified:   x/staking/types/expected_keepers.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
(cherry picked from commit c3ae0b0)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from a team as a code owner August 3, 2023 22:56
@mergify mergify bot added the conflicts label Aug 3, 2023
@alexanderbez alexanderbez enabled auto-merge (squash) August 3, 2023 23:07
@alexanderbez alexanderbez merged commit 69db56b into release/v0.50.x Aug 3, 2023
@alexanderbez alexanderbez deleted the mergify/bp/release/v0.50.x/pr-17164 branch August 3, 2023 23:13
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants