Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/v2): fix variable arguments #17313

Merged
merged 18 commits into from
Sep 26, 2023
Merged

fix(client/v2): fix variable arguments #17313

merged 18 commits into from
Sep 26, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 7, 2023

Description

Support repeated coins.
EDIT: It turns out it was an issue with repeated coins.

There is no easy way to support coins as: 1000stake,100bar, with AutoCLI, the way to go will be 1000stake 100bar instead.

ref: #17478

follow-up of: #17306, #17707


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 7, 2023
@julienrbrt
Copy link
Member Author

Closing this, I'll re-create a PR for it.

@julienrbrt julienrbrt closed this Sep 13, 2023
@julienrbrt julienrbrt deleted the julien/autocli-coin branch September 13, 2023 10:42
@julienrbrt julienrbrt mentioned this pull request Sep 13, 2023
20 tasks
@julienrbrt julienrbrt restored the julien/autocli-coin branch September 21, 2023 11:07
@julienrbrt julienrbrt reopened this Sep 21, 2023
@julienrbrt julienrbrt changed the title fix(client/v2): support repeated coins fix(client/v2): fix variable arguments Sep 25, 2023
@julienrbrt julienrbrt marked this pull request as ready for review September 25, 2023 11:16
@julienrbrt julienrbrt requested a review from a team as a code owner September 25, 2023 11:16
@github-actions github-actions bot removed the C:x/bank label Sep 25, 2023
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@@ -36,6 +38,10 @@ func (c *coinValue) String() string {
}

func (c *coinValue) Set(stringValue string) error {
if strings.Contains(stringValue, ",") {
return fmt.Errorf("coin flag must be a single coin, specific multiple coins with multiple flags or spaces")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return fmt.Errorf("coin flag must be a single coin, specific multiple coins with multiple flags or spaces")
return fmt.Errorf("coin flag must be a single coin, specify multiple coins with multiple flags or spaces")

@julienrbrt julienrbrt added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 4600d00 Sep 26, 2023
50 checks passed
@julienrbrt julienrbrt deleted the julien/autocli-coin branch September 26, 2023 12:11
mergify bot pushed a commit that referenced this pull request Sep 26, 2023
julienrbrt added a commit that referenced this pull request Sep 26, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants