Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client,simapp): inject keyring in autocli opts #17351

Merged
merged 13 commits into from
Aug 14, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 10, 2023

Description

ref: #17107
follow-up of #17308

Let SDK keyring implement the clientv2 keyring interface.
This allows to use the keyring in all commands in autocli by apps built by the SDK.
The same will be done for Hubl in #17107.

Changes:

Before:

$ simd q bank balances cosmos1gaa77tmlsr5qkkfl0uxk4z6lwdjgwzg2dzfada
$ simd q bank balances $(simd keys show alice -a)
$ simd tx bank send alice $(simd keys show bob -a) 1000stake

After:

$ simd q bank balances cosmos1gaa77tmlsr5qkkfl0uxk4z6lwdjgwzg2dzfada
$ simd q bank balances alice
$ simd tx bank send alice bob 1000stake # eventually migrated to autocli

And this in any commands.

Note, the only drawback is that it is not possible to overwrite the keyring with command flags, only the client.toml is read for now.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner August 10, 2023 13:02
@github-actions github-actions bot added the C:CLI label Aug 10, 2023
@julienrbrt julienrbrt added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release and removed C:CLI labels Aug 10, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot added the C:CLI label Aug 10, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments otherwise looks good

simapp/simd/cmd/root.go Show resolved Hide resolved
simapp/simd/cmd/root_v2.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added this pull request to the merge queue Aug 14, 2023
@julienrbrt julienrbrt removed this pull request from the merge queue due to a manual request Aug 14, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit bf92632 Aug 14, 2023
49 checks passed
@julienrbrt julienrbrt deleted the julien/keyring-sdk branch August 14, 2023 14:10
mergify bot pushed a commit that referenced this pull request Aug 14, 2023
(cherry picked from commit bf92632)

# Conflicts:
#	client/config/config.go
#	docs/docs/building-modules/10-autocli.md
julienrbrt added a commit that referenced this pull request Aug 14, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants