Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: format proto files #17445

Merged
merged 4 commits into from
Aug 18, 2023
Merged

chore: format proto files #17445

merged 4 commits into from
Aug 18, 2023

Conversation

tac0turtle
Copy link
Member

Description

format proto files according to clangformat

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review August 18, 2023 11:36
@tac0turtle tac0turtle requested a review from a team as a code owner August 18, 2023 11:36
@julienrbrt
Copy link
Member

Is this the output of make proto-format ?

@tac0turtle
Copy link
Member Author

Is this the output of make proto-format ?

first time via clangformat manually second time make proto-format, the outputs are the same

@julienrbrt
Copy link
Member

julienrbrt commented Aug 18, 2023 •
edited
Loading

Is this the output of make proto-format ?

first time via clangformat manually second time make proto-format, the outputs are the same

Cool, should we have this run every time we call make proto-gen?
Personally, I never run make proto-format 😅

@tac0turtle
Copy link
Member Author

sure i can add it

@tac0turtle tac0turtle added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 066f8a7 Aug 18, 2023
44 of 48 checks passed
@tac0turtle tac0turtle deleted the marko/format_proto branch August 18, 2023 14:08
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 18, 2023
@tac0turtle @mergify
chore: format proto files (#17445)
6ca32bb 
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
(cherry picked from commit 066f8a7)

# Conflicts:
#	api/cosmos/autocli/v1/options.pulsar.go
#	proto/cosmos/autocli/v1/options.proto
@mergify mergify bot mentioned this pull request Aug 18, 2023
Merged
julienrbrt
julienrbrt reviewed Aug 18, 2023
View reviewed changes
scripts/protocgen.sh
@@ -35,3 +35,6 @@ rm -rf github.com cosmossdk.io
go mod tidy

./scripts/protocgen-pulsar.sh

echo "Formatting protobuf files"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be at the beginning of the file, like 77f1ef5.
I had to run it twice in #17447 otherwise.

julienrbrt added a commit that referenced this pull request Aug 18, 2023
@mergify @tac0turtle @julienrbrt
chore: format proto files (backport #17445) (#17447)
657add7 
Co-authored-by: Marko <marko@baricevic.me>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@samricotta samricotta Awaiting requested review from samricotta

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees

@julienrbrt julienrbrt

@samricotta samricotta

Labels
C:CLI C:orm C:x/gov C:x/tx Type: Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @julienrbrt @samricotta