Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/nft): add autocli options for tx #17825

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 20, 2023

Description

Closes: #17824

Blocked on #17913


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

x/nft/module/autocli.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt changed the title feat(x/nft)!: add autocli options for tx feat(x/nft): add autocli options for tx Sep 20, 2023
@julienrbrt julienrbrt changed the base branch from main to julien/autocli-from October 4, 2023 14:49
@julienrbrt julienrbrt added the S:blocked Status: Blocked label Oct 4, 2023
@julienrbrt julienrbrt marked this pull request as ready for review October 4, 2023 14:51
@julienrbrt julienrbrt requested a review from a team as a code owner October 4, 2023 14:51
@github-actions

This comment has been minimized.

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Oct 4, 2023
@julienrbrt julienrbrt requested review from a team, tac0turtle and testinginprod and removed request for a team October 4, 2023 16:09
Base automatically changed from julien/autocli-from to main October 5, 2023 11:06
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Oct 5, 2023

### Features

* [#17825](https://github.com/cosmos/cosmos-sdk/pull/17825) Add AutoCLI Options.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [#17825](https://github.com/cosmos/cosmos-sdk/pull/17825) Add AutoCLI Options.
*(x/nft) [#17825](https://github.com/cosmos/cosmos-sdk/pull/17825) Add AutoCLI Options.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary as it's in the nft changelog

@julienrbrt julienrbrt added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit c0d2d70 Oct 5, 2023
51 checks passed
@julienrbrt julienrbrt deleted the julien/autocli-tx-nft branch October 5, 2023 12:07
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit c0d2d70)

# Conflicts:
#	x/nft/client/cli/tx_test.go
julienrbrt added a commit that referenced this pull request Oct 5, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/nft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoCLI Tx Options for x/nft
2 participants