test(client/keys): deflake Test_runImportHexCmd by a unique directory per sub-test run #17855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per test run Fixes undefined behavior that could result in test flakes on various environments by creating a unique directory per sub-test run of Test_runImportHexCmd. (*testing).T.TempDir() must not be mucked around with. Fixes #17854
julienrbrt
changed the title
julienrbrt
approved these changes
Sep 25, 2023
julienrbrt
added
the
backport/v0.50.x
julienrbrt
deleted the
client-keys-use-proper-own-dir-per-Test_runImportHexCmd-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes undefined behavior that could result in test flakes on various environments by creating a unique directory per sub-test run of Test_runImportHexCmd. (*testing).T.TempDir() must not be mucked around with.
Fixes #17854