Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(server): use bootstrap api from comet #17899

Merged
merged 3 commits into from
Sep 27, 2023
Merged

refactor(server): use bootstrap api from comet #17899

merged 3 commits into from
Sep 27, 2023

Conversation

tac0turtle
Copy link
Member

Description

remove home grown version of bootstrap api

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner September 27, 2023 11:36
julienrbrt
julienrbrt approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@julienrbrt julienrbrt changed the title chore: use bootstrap api from comet refactor(server): use bootstrap api from comet Sep 27, 2023
julienrbrt
julienrbrt reviewed Sep 27, 2023
View reviewed changes
server/cmt_cmds.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@tac0turtle tac0turtle added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 1be29b7 Sep 27, 2023
50 checks passed
@tac0turtle tac0turtle deleted the marko/update_bootstrap_api branch September 27, 2023 17:27
@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.50.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 19, 2024 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 19, 2024
@tac0turtle @mergify
refactor(server): use bootstrap api from comet (#17899)
62cbf25 
(cherry picked from commit 1be29b7)
@mergify mergify bot mentioned this pull request Jan 19, 2024
Merged
julienrbrt pushed a commit that referenced this pull request Jan 19, 2024
@mergify @tac0turtle
refactor(server): use bootstrap api from comet (backport #17899) (#19150
d0c414e 
)

Co-authored-by: Marko <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees

@julienrbrt julienrbrt

@likhita-809 likhita-809

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tac0turtle @julienrbrt @alexanderbez @likhita-809