Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store/v1): Do not panic on prune in Commit #18897

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

itsdevbear
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@itsdevbear itsdevbear requested a review from a team as a code owner December 27, 2023 03:07
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: changelog

@alexanderbez alexanderbez added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Dec 27, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to make sure this lands on main, also what are the implications here? would we prune later on or never @cool-develope

@alexanderbez
Copy link
Contributor

The core implication is that pruning execution does NOT impact consensus. So for example something borked in pruning (e.g. disk IO failure or logic failure), we don't want that to impact consensus as it's unrelated.

In store v2, we'd return an error here. But for <= 0.50, we should avoid the panic.

@tac0turtle tac0turtle merged commit f08c8cc into cosmos:release/v0.50.x Dec 27, 2023
42 of 45 checks passed
@tac0turtle tac0turtle deleted the prune branch December 27, 2023 17:47
@tac0turtle
Copy link
Member

nvm we dont have to get this on main, only need to tag 1.0.1, ill add the changelog

@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants