rename blacklist to blocked

[colin-axner]

Description

Renamed to CannotSendTo. The golang renamings were blockListed and ignoreListed. I wanted to stay away from block because I could see that being confused for actual blocks on the chain and ignore doesn't feel as self-describable as CannotSendTo.

If someone has a name they think works better, I'll gladly update this pr again 👍

closes: #6447

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

[codecov]

Codecov Report

Merging #6455 into master will not change coverage.
The diff coverage is 80.95%.

@@           Coverage Diff           @@
##           master    #6455   +/-   ##
=======================================
  Coverage   55.98%   55.98%           
=======================================
  Files         466      466           
  Lines       27908    27908           
=======================================
  Hits        15623    15623           
  Misses      11180    11180           
  Partials     1105     1105           

[fedekunze]

LGTM. What about denylist or disabledlist? @tessr has good ideas too regarding this

[colin-axner]

LGTM. What about denylist or disabledlist? @tessr has good ideas too regarding this

I'd be fine with denyList (not sure if we want Recv in there). disable implies possibility of re-enabling, but that is not possible since this list is statically created/set (and for security won't change)

[tessr]

Woo, thanks for doing this! I agree that blockList would be confusing and I like the emphasis on being as descriptive as possible.

My question would be, what is the reason that you cannot send to these addresses? Is it that they've been blocked because they're bad in some way? Would blockedList be confusing, too? Or blockedAddrs? cannotSendTo is basically fine, but I think it's not just that you cannot send to these addresses but that you should not, right?

Another possibility is banList/bannedAddrs.

Anyways, this is all a bike shed and I'm just happy we're switching to more neutral language!

[colin-axner]

My question would be, what is the reason that you cannot send to these addresses? Is it that they've been blocked because they're bad in some way? Would blockedList be confusing, too? Or blockedAddrs? cannotSendTo is basically fine, but I think it's not just that you cannot send to these addresses but that you should not, right?

If I remember correctly, those addresses aren't "bad", but they just don't support correct adjustment of supply and therefore cause supply invariants to break.

I think blockedAddrs works well. I don't think there is any particular reason list needs to be in the name, especially since it is a map. Will update to that 👍

[alexanderbez]

Excellent <3