Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Fix BIP44 coin type #480

Merged
merged 6 commits into from
Aug 28, 2020
Merged

Fix BIP44 coin type #480

merged 6 commits into from
Aug 28, 2020

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Aug 28, 2020

Closes: #406

Description

We were using Cosmos' default fundraiser HDPath (m/44'/118'/0'/0) instead of Ethereum's one, as defined by EIP84 (m/44'/60'/0'/0).


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze requested a review from noot as a code owner August 28, 2020 09:25
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@6307ba9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #480   +/-   ##
==============================================
  Coverage               ?   69.99%           
==============================================
  Files                  ?       38           
  Lines                  ?     2493           
  Branches               ?        0           
==============================================
  Hits                   ?     1745           
  Misses                 ?      617           
  Partials               ?      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6307ba9...f3a52de. Read the comment docs.

@fedekunze fedekunze merged commit 8a3692e into development Aug 28, 2020
@fedekunze fedekunze deleted the hdpath branch August 28, 2020 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document how to present two kinds of address (cosmos and eth)
2 participants