Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

atto photon refactor #503

Merged
merged 5 commits into from
Sep 8, 2020
Merged

atto photon refactor #503

merged 5 commits into from
Sep 8, 2020

Conversation

fedekunze
Copy link
Contributor

Description

  • add utility functions for atto photon
  • add an additional coin-denom flag to testnet command in order to remove testnet command on Aragon Chain

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #503 into development will decrease coverage by 0.08%.
The diff coverage is 27.27%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #503      +/-   ##
===============================================
- Coverage        71.81%   71.73%   -0.09%     
===============================================
  Files               40       41       +1     
  Lines             2679     2685       +6     
===============================================
+ Hits              1924     1926       +2     
- Misses             614      618       +4     
  Partials           141      141              
Impacted Files Coverage Δ
types/account.go 62.16% <0.00%> (ø)
types/coin.go 33.33% <33.33%> (ø)
x/evm/types/params.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b485542...57d06da. Read the comment docs.

@fedekunze fedekunze marked this pull request as ready for review September 8, 2020 14:06
@fedekunze fedekunze requested a review from noot as a code owner September 8, 2020 14:06
@fedekunze fedekunze merged commit 1505ba8 into development Sep 8, 2020
@fedekunze fedekunze deleted the fedekunze/atto-photon branch September 8, 2020 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants