-
Notifications
You must be signed in to change notification settings - Fork 161
Conversation
@@ -37,17 +36,11 @@ func InitGenesis(ctx sdk.Context, k Keeper, accountKeeper types.AccountKeeper, d | |||
} | |||
|
|||
evmBalance := acc.GetCoins().AmountOf(evmDenom) | |||
if !evmBalance.Equal(account.Balance) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved this check to the invariant
|
||
k.SetBalance(ctx, address, account.Balance.BigInt()) | ||
k.SetNonce(ctx, address, acc.GetSequence()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this setter was missing
Looks like the command is not working as intended though: steps to reproduce:
Output:
There are no relevant error messages that come out in the ethermintd and ethermintcli logs |
Why can this pr close issue314? |
Because the invariant check that is run on every block ensures the accounting is correct (see the function on files). For this, you have to run a node in the invariant mode |
@araskachoi this PR is not related with the app export logic you mentioned. Although I just checked it on my own and it worked all right 👍 :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left a couple of questions
closes #314