-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All cosmos hub code should live here #1696
Comments
I remember at the beginning of Cosmos everything was inside gaia repo, it has been separated after a while. I think some very hub-specific modules can maybe be moved here, importing everything will cause unnecessary copy-paste and boilerplate code between the two repos |
Thanks @faddat , we have imported some modules directly into the repo, will assess whether we want the same with these. Thanks for starting this discussion. We have an upcoming session to look at a number of technical debt issues, possible to address then. |
hey @faddat mauth is the first module being maintained by the gaia integration team and so lives in the repo. |
hey @faddat |
hey, questions:
When we worked on https://github.com/pylons-tech/pylons the productivity boost gained from moving everything to a single repository was enormous. I think that moving those two here would help flow a great deal. I'll make an example PR for liquidity.. should show just how much smoother that'd make things |
@faddat I opened this issue for the Liquidity module. Regarding the packet forward middleware module, that's for now maintain and updated by Strangelove. We'll asses at a later date the need for the module. |
Summary
Currently, working on the hub is harder than it needs to be because we've got to upgrade the liquidity module and/or the IBC router.
The best way to deal with this, is for modules imported by gaia, to live in gaia (especially if like the liquidity module and the ibc router, they were built primarily for gaia).
This would exclude:
And include anything else, like the liquidity module and the IBC router.
Type
Build and code debt
Impact
By moving key modules into gaia's repository, it becomes easier to maintain gaia, and PR's will require less coordination.
Proposed Solution
For now, the easiest path is to move the liquidity module and the IBC router into this repository.
For Admin Use
The text was updated successfully, but these errors were encountered: