Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the code in global fee #2321

Closed
5 tasks
yaruwangway opened this issue Mar 22, 2023 · 0 comments · Fixed by #2316
Closed
5 tasks

improve the code in global fee #2321

yaruwangway opened this issue Mar 22, 2023 · 0 comments · Fixed by #2316
Assignees
@sainoe
Labels
status: waiting-triage This issue/PR has not yet been triaged by the team. type: feature-request New feature or request improvement

Comments

@yaruwangway
Copy link
Contributor

Summary

As part of the global fee refactor #2270, the following items which does not change the fee check logics will be also done:

  • simplify the logics
  • add more test cases, for example, adding test for getMinGasPrices
  • simplify the test, for example, try to use *testing.T rather than *feeUtilsTestSuite

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@yaruwangway yaruwangway added type: feature-request New feature or request improvement status: waiting-triage This issue/PR has not yet been triaged by the team. labels Mar 22, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Mar 22, 2023
@yaruwangway yaruwangway moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Mar 22, 2023
This was referenced Mar 22, 2023
Merged
Closed
@mpoke mpoke assigned yaruwangway and sainoe and unassigned yaruwangway Apr 2, 2023
@mpoke mpoke moved this from 🏗 In progress to 👀 In review in Cosmos Hub Apr 2, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
status: waiting-triage This issue/PR has not yet been triaged by the team. type: feature-request New feature or request improvement
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

global fee refactor cosmos/gaia
2 participants
@sainoe @yaruwangway