You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Presently, in cosmoshub, each transaction has to pay fees except bypass-min-fee-msg-types within a certain gas limit (MaxBypassMinFeeMsgGasUsage).
Each node can setup its own bypass-min-fee-msg-types. MaxTotalBypassMinFeeMsgGasUsage is a variable in hardcoded. As a result, it is not clear which msg can be bypassed and if the msgs can bypass min fee is uncertain.
The bypass-min-fee-msg-types and MaxTotalBypassMinFeeMsgGasUsage will move to params so that they can be changed by gov proposal, and the whole network accept the same bypass msgs and bypass gas limit. The bypass-min-fee-msg-types and MaxTotalBypassMinFeeMsgGasUsage can be also queried, so that for transaction submitter, it is clear what msgs can be bypassed.
Moving bypass-min-fee-msg-types and MaxTotalBypassMinFeeMsgGasUsage to params is also allows fee check in deliverTX. Details please check here.
Please note, the above mentioned refactor is State breaking !!!
Proposal
This refactor will include:
add bypassMinFeeMsgTypes and MaxTotalBypassMinFeeMsgGasUsage to global fee params. For example, when query global fee, can get the following params:
add validationFn for bypassMinFeeMsgTypes and MaxTotalBypassMinFeeMsgGasUsage.
add migration, when migrating from v9 -> v10, bypass_min_fee_msg_types=[ "/ibc.core.channel.v1.MsgRecvPacket", "/ibc.core.channel.v1.MsgAcknowledgement", "/ibc.core.client.v1.MsgUpdateClient", "/ibc.core.channel.v1.MsgTimeout", "/ibc.core.channel.v1.MsgTimeoutOnClose"] and max_total_bypass_minFee_msg_gas_usage=1000000 will be set as default.
removebypass-min-fee-msg-types from config. please check this issue
The text was updated successfully, but these errors were encountered:
Problem
Presently, in cosmoshub, each transaction has to pay fees except
bypass-min-fee-msg-types
within a certain gas limit (MaxBypassMinFeeMsgGasUsage
).Each node can setup its own
bypass-min-fee-msg-types
.MaxTotalBypassMinFeeMsgGasUsage
is a variable in hardcoded. As a result, it is not clear which msg can be bypassed and if the msgs can bypass min fee is uncertain.The
bypass-min-fee-msg-types
andMaxTotalBypassMinFeeMsgGasUsage
will move to params so that they can be changed by gov proposal, and the whole network accept the same bypass msgs and bypass gas limit. Thebypass-min-fee-msg-types
andMaxTotalBypassMinFeeMsgGasUsage
can be also queried, so that for transaction submitter, it is clear what msgs can be bypassed.Moving
bypass-min-fee-msg-types
andMaxTotalBypassMinFeeMsgGasUsage
to params is also allows fee check indeliverTX
. Details please check here.Please note, the above mentioned refactor is State breaking !!!
Proposal
This refactor will include:
bypassMinFeeMsgTypes
andMaxTotalBypassMinFeeMsgGasUsage
to global fee params. For example, when query global fee, can get the following params:bypassMinFeeMsgTypes
andMaxTotalBypassMinFeeMsgGasUsage
.bypass_min_fee_msg_types=[ "/ibc.core.channel.v1.MsgRecvPacket", "/ibc.core.channel.v1.MsgAcknowledgement", "/ibc.core.client.v1.MsgUpdateClient", "/ibc.core.channel.v1.MsgTimeout", "/ibc.core.channel.v1.MsgTimeoutOnClose"]
andmax_total_bypass_minFee_msg_gas_usage=1000000
will be set as default.bypass-min-fee-msg-types
from config. please check this issueThe text was updated successfully, but these errors were encountered: