Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hermes docker builder isn't run in E2E tests #2659

Closed
5 tasks
sainoe opened this issue Jul 21, 2023 · 2 comments
Closed
5 tasks

Hermes docker builder isn't run in E2E tests #2659

sainoe opened this issue Jul 21, 2023 · 2 comments
Assignees
@sainoe
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth type: tech-debt Slows down development in the long run

Comments

@sainoe
Copy link
Contributor

sainoe commented Jul 21, 2023

Summary

#2644 updated the Hermes builder to version 1.5.1, however the E2E tests setup wasn't updated accordingly.

Proposed Solution

  • Ensure the E2E tests run the Hermes builder's image
    see hermes.Dockerfile

  • Update the E2E tests to pass using the Hermes builder's version

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@sainoe sainoe added the type: tech-debt Slows down development in the long run label Jul 21, 2023
@sainoe sainoe self-assigned this Jul 21, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jul 21, 2023
@sainoe sainoe moved this from 🩹 Triage to 🏗 In progress in Cosmos Hub Jul 21, 2023
@MSalopek
Copy link
Contributor

Just a note, v1.6.0 is out:
https://github.com/informalsystems/hermes/releases/tag/v1.6.0

@sainoe sainoe moved this from 🏗 F3: InProgress to 📥 F2: Todo in Cosmos Hub Sep 7, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 15, 2023
@MSalopek MSalopek mentioned this issue Dec 8, 2023
Merged
8 tasks
@MSalopek MSalopek moved this from 📥 F2: Todo to 👀 F3: InReview in Cosmos Hub Dec 8, 2023
@sainoe
Copy link
Contributor Author

sainoe commented Dec 15, 2023

Closed by #2841.

@sainoe sainoe closed this as completed Dec 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Dec 15, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainoe sainoe

Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth type: tech-debt Slows down development in the long run
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpoke @sainoe @MSalopek