feat(v1.x.x): async pruning of orphan nodes #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8c630d.
czarcas7ic
changed the title
|
overall, looks good to me! could you please add the changelog? |
|
Done here 8b53289 @cool-develope would you consider making a minor v1 release that includes this? If not we can just use our fork but would be nice to just use a tag from iavl proper. |
ValarDragon
approved these changes
Feb 2, 2024
Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
|
@cool-develope would we be able to get this in a v1 release? I am also refraining from merging since I am not aware of the rules/requirements for this repo. |
|
@tac0turtle ☝️ |
cool-develope
changed the title
|
Thanks for working on this! @cool-develope are you looking to create a minor release off this and if so, may I ask when we should expect it? |
|
we can do a release this week for it |
|
Nit: the PR description should say "asynchronously" ? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature prevents the multiple hour long waiting period when chains upgrade from previous versions of IAVL to IAVL v1. The time comes from pruning orphan nodes. This synchronously prunes them. This branch has been tested successfully against osmosis mainnet.