From 4580f769b88c930025c054edf0e75a6d513c7797 Mon Sep 17 00:00:00 2001 From: Jacob Gadikian Date: Sat, 10 Jun 2023 11:57:56 +0800 Subject: [PATCH] restructure modules --- modules/apps/27-interchain-accounts/module.go | 9 --------- modules/apps/29-fee/module.go | 9 --------- modules/apps/transfer/module.go | 9 --------- modules/capability/module.go | 3 +-- modules/core/module.go | 4 ++-- 5 files changed, 3 insertions(+), 31 deletions(-) diff --git a/modules/apps/27-interchain-accounts/module.go b/modules/apps/27-interchain-accounts/module.go index 911b1d36466..81bff16844e 100644 --- a/modules/apps/27-interchain-accounts/module.go +++ b/modules/apps/27-interchain-accounts/module.go @@ -195,15 +195,6 @@ func (am AppModule) ExportGenesis(ctx sdk.Context, cdc codec.JSONCodec) json.Raw // ConsensusVersion implements AppModule/ConsensusVersion. func (AppModule) ConsensusVersion() uint64 { return 3 } -// BeginBlock implements the AppModule interface -func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) { -} - -// EndBlock implements the AppModule interface -func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate { - return []abci.ValidatorUpdate{} -} - // AppModuleSimulation functions // GenerateGenesisState creates a randomized GenState of the ics27 module. diff --git a/modules/apps/29-fee/module.go b/modules/apps/29-fee/module.go index 13b45a68825..51bd125d001 100644 --- a/modules/apps/29-fee/module.go +++ b/modules/apps/29-fee/module.go @@ -117,15 +117,6 @@ func (am AppModule) ExportGenesis(ctx sdk.Context, cdc codec.JSONCodec) json.Raw // ConsensusVersion implements AppModule/ConsensusVersion. func (AppModule) ConsensusVersion() uint64 { return 1 } -// BeginBlock implements the AppModule interface -func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) { -} - -// EndBlock implements the AppModule interface -func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate { - return []abci.ValidatorUpdate{} -} - // AppModuleSimulation functions // GenerateGenesisState creates a randomized GenState of the 29-fee module. diff --git a/modules/apps/transfer/module.go b/modules/apps/transfer/module.go index 85cb1adb548..cc35bca1bff 100644 --- a/modules/apps/transfer/module.go +++ b/modules/apps/transfer/module.go @@ -136,15 +136,6 @@ func (am AppModule) ExportGenesis(ctx sdk.Context, cdc codec.JSONCodec) json.Raw // ConsensusVersion implements AppModule/ConsensusVersion defining the current version of transfer. func (AppModule) ConsensusVersion() uint64 { return 4 } -// BeginBlock implements the AppModule interface -func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) { -} - -// EndBlock implements the AppModule interface -func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate { - return []abci.ValidatorUpdate{} -} - // AppModuleSimulation functions // GenerateGenesisState creates a randomized GenState of the transfer module. diff --git a/modules/capability/module.go b/modules/capability/module.go index 829d615cfeb..27bcd87d51e 100644 --- a/modules/capability/module.go +++ b/modules/capability/module.go @@ -26,7 +26,6 @@ import ( ) var ( - _ module.BeginBlockAppModule = (*AppModule)(nil) _ module.AppModuleBasic = (*AppModuleBasic)(nil) _ module.AppModuleSimulation = (*AppModule)(nil) _ appmodule.AppModule = (*AppModule)(nil) @@ -143,7 +142,7 @@ func (AppModule) ConsensusVersion() uint64 { return 1 } // BeginBlock executes all ABCI BeginBlock logic respective to the capability module. // BeginBlocker calls InitMemStore to assert that the memory store is initialized. // It's safe to run multiple times. -func (am AppModule) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { +func (am AppModule) BeginBlock(ctx sdk.Context) { defer telemetry.ModuleMeasureSince(types.ModuleName, time.Now(), telemetry.MetricKeyBeginBlocker) am.keeper.InitMemStore(ctx) diff --git a/modules/core/module.go b/modules/core/module.go index 2a64a49cc7d..cdf6e63b3f3 100644 --- a/modules/core/module.go +++ b/modules/core/module.go @@ -171,13 +171,13 @@ func (am AppModule) ExportGenesis(ctx sdk.Context, cdc codec.JSONCodec) json.Raw func (AppModule) ConsensusVersion() uint64 { return 5 } // BeginBlock returns the begin blocker for the ibc module. -func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) { +func (am AppModule) BeginBlock(ctx sdk.Context) { ibcclient.BeginBlocker(ctx, am.keeper.ClientKeeper) } // EndBlock returns the end blocker for the ibc module. It returns no validator // updates. -func (am AppModule) EndBlock(ctx sdk.Context, req abci.RequestEndBlock) []abci.ValidatorUpdate { +func (am AppModule) EndBlock(ctx sdk.Context) []abci.ValidatorUpdate { return []abci.ValidatorUpdate{} }