From 6d3c70fda88923ddc0840d2008cfaeec8f46b2b5 Mon Sep 17 00:00:00 2001
From: DimitrisJim <d.f.hilliard@gmail.com>
Date: Thu, 20 Jul 2023 23:32:43 +0300
Subject: [PATCH] Add failure case for msg failing on ValidateBasic.

---
 .../host/keeper/relay_test.go                 | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/modules/apps/27-interchain-accounts/host/keeper/relay_test.go b/modules/apps/27-interchain-accounts/host/keeper/relay_test.go
index 220a88073a64..39dcf161fb67 100644
--- a/modules/apps/27-interchain-accounts/host/keeper/relay_test.go
+++ b/modules/apps/27-interchain-accounts/host/keeper/relay_test.go
@@ -330,6 +330,45 @@ func (suite *KeeperTestSuite) TestOnRecvPacket() {
 			},
 			true,
 		},
+		{
+			"Msg fails its ValidateBasic: MsgTransfer has an empty receiver",
+			func(encoding string) {
+				transferPath := ibctesting.NewPath(suite.chainB, suite.chainC)
+				transferPath.EndpointA.ChannelConfig.PortID = ibctesting.TransferPort
+				transferPath.EndpointB.ChannelConfig.PortID = ibctesting.TransferPort
+				transferPath.EndpointA.ChannelConfig.Version = transfertypes.Version
+				transferPath.EndpointB.ChannelConfig.Version = transfertypes.Version
+
+				suite.coordinator.Setup(transferPath)
+
+				interchainAccountAddr, found := suite.chainB.GetSimApp().ICAHostKeeper.GetInterchainAccountAddress(suite.chainB.GetContext(), ibctesting.FirstConnectionID, path.EndpointA.ChannelConfig.PortID)
+				suite.Require().True(found)
+
+				msg := &transfertypes.MsgTransfer{
+					SourcePort:       transferPath.EndpointA.ChannelConfig.PortID,
+					SourceChannel:    transferPath.EndpointA.ChannelID,
+					Token:            sdk.NewCoin(sdk.DefaultBondDenom, sdkmath.NewInt(100)),
+					Sender:           interchainAccountAddr,
+					Receiver:         "",
+					TimeoutHeight:    suite.chainB.GetTimeoutHeight(),
+					TimeoutTimestamp: uint64(0),
+				}
+
+				data, err := icatypes.SerializeCosmosTx(suite.chainA.GetSimApp().AppCodec(), []proto.Message{msg}, encoding)
+				suite.Require().NoError(err)
+
+				icaPacketData := icatypes.InterchainAccountPacketData{
+					Type: icatypes.EXECUTE_TX,
+					Data: data,
+				}
+
+				packetData = icaPacketData.GetBytes()
+
+				params := types.NewParams(true, []string{sdk.MsgTypeURL(msg)})
+				suite.chainB.GetSimApp().ICAHostKeeper.SetParams(suite.chainB.GetContext(), params)
+			},
+			false,
+		},
 		{
 			"unregistered sdk.Msg",
 			func(encoding string) {