Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish verifyMisbehaviour chainID revision tests #1184

Closed
3 tasks
colin-axner opened this issue Mar 28, 2022 · 2 comments
Closed
3 tasks

Finish verifyMisbehaviour chainID revision tests #1184

colin-axner opened this issue Mar 28, 2022 · 2 comments
Assignees
@colin-axner
Labels
02-client 07-tendermint
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

There are a few tests from #1166 which are commented out. They should be completed once a Endpoint{}.UpgradeChain() function is added.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner self-assigned this Mar 28, 2022
@seantking
Copy link
Contributor

verifyHeader needs the respective tests also. The remaining test cases needed to be ported over are still being tested as part of the CheckHeaderAndUpdateState function.

@crodriguezvega crodriguezvega added this to the 02-client refactor milestone Mar 30, 2022
@colin-axner colin-axner mentioned this issue Apr 26, 2022
Merged
9 tasks
@colin-axner
Copy link
Contributor Author

closed by #1302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
02-client 07-tendermint
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor alpha
Development

No branches or pull requests
3 participants
@crodriguezvega @seantking @colin-axner