Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune a consensus state on duplicate client updates #1207

Closed
3 tasks
colin-axner opened this issue Mar 31, 2022 · 1 comment · Fixed by #2965
Closed
3 tasks

Prune a consensus state on duplicate client updates #1207

colin-axner opened this issue Mar 31, 2022 · 1 comment · Fixed by #2965
Assignees
@damiannolan
Labels
02-client 07-tendermint
Milestone
v7.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Currently after performing many changes to the 02-client-refactor branch, a duplicate update will not perform the normal pruning of the oldest consensus state (if expired). I propose we restructure the code such that pruning happens first. See code

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added needs discussion Issues that need discussion before they can be worked on 07-tendermint 02-client labels Mar 31, 2022
@crodriguezvega
Copy link
Contributor

Would the work be moving this line before this line + adapting/adding any necessary tests?

@crodriguezvega crodriguezvega added this to the v7.0.0 milestone Dec 12, 2022
@colin-axner colin-axner removed the needs discussion Issues that need discussion before they can be worked on label Dec 15, 2022
@damiannolan damiannolan self-assigned this Dec 21, 2022
@damiannolan damiannolan mentioned this issue Dec 21, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
02-client 07-tendermint
Projects
ibc-go
Status: Done 🥳
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

chore: prune expired consensus states on duplicate header updates cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @colin-axner