Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert merkle path is non empty for solomachine #1916

Closed
3 tasks
colin-axner opened this issue Aug 8, 2022 · 0 comments · Fixed by #2741
Closed
3 tasks

Assert merkle path is non empty for solomachine #1916

colin-axner opened this issue Aug 8, 2022 · 0 comments · Fixed by #2741
Assignees
@charleenfei
Labels
06-solomachine
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

In VerifyMembership, an additional assertion should be added to ensure the path is non empty. The solo machine should never sign over an empty path

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
06-solomachine
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor beta
Development

Successfully merging a pull request may close this issue.

fix: added check for empty path in 06-solomachine cosmos/ibc-go
2 participants
@charleenfei @colin-axner