Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug logging for failed acknowledgement errors #2725

Closed
3 tasks
colin-axner opened this issue Nov 10, 2022 · 2 comments · Fixed by #3077
Closed
3 tasks

Add debug logging for failed acknowledgement errors #2725

colin-axner opened this issue Nov 10, 2022 · 2 comments · Fixed by #3077
Assignees
@GNaD13
Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@colin-axner
Copy link
Contributor

Summary

In the same spirit as #2713, we should add debug level logging for the error message which is discarded when generated a failed acknowledgement. This should occur for:

  • 20-transfer
  • 27-interchain-accounts (host)
  • 29-fee

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. label Nov 10, 2022
@GNaD13
Copy link
Contributor

GNaD13 commented Jan 27, 2023

Hi @colin-axner, can I take this issue?

@crodriguezvega
Copy link
Contributor

@GNaD13 Yes, you can take this issue. Thanks!

Please have a look at the PR that closed the issue #2713 mentioned above for reference.

@GNaD13 GNaD13 mentioned this issue Jan 28, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GNaD13 GNaD13

Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add log message for debug error failed acknowledgement errors notional-labs/ibc-go
3 participants
@crodriguezvega @colin-axner @GNaD13