Do not discard page result in ics29-fee queries #2894
Labels
29-fee
good first issue
Good for newcomers
type: code hygiene
Clean up code but without changing functionality or interfaces
There are three queries for ics29-fee whose requests accept a pagination argument, but the page response is not present in the response. One example:
QueryIncentivizedPacketsRequest
has a page request parameter, which is used in the gRPC endpoint, but the page result is discarded.Same thing happens for
QueryIncentivizedPacketsForChannelRequest
here andQueryFeeEnabledChannelsRequest
here.I would propose not to discard the page result and add it to the corresponding responses, so that we are consistent with other paginated queries. This change extends the API, so would not be API breaking, but it would be state machine breaking, I believe. There is no need to backport it.
The text was updated successfully, but these errors were encountered: