Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not discard page result in ics29-fee queries #2894

Closed
crodriguezvega opened this issue Dec 6, 2022 · 0 comments · Fixed by #3054
Closed

Do not discard page result in ics29-fee queries #2894

crodriguezvega opened this issue Dec 6, 2022 · 0 comments · Fixed by #3054
Labels
29-fee good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Dec 6, 2022

There are three queries for ics29-fee whose requests accept a pagination argument, but the page response is not present in the response. One example: QueryIncentivizedPacketsRequest has a page request parameter, which is used in the gRPC endpoint, but the page result is discarded.

Same thing happens for QueryIncentivizedPacketsForChannelRequest here and QueryFeeEnabledChannelsRequest here.

I would propose not to discard the page result and add it to the corresponding responses, so that we are consistent with other paginated queries. This change extends the API, so would not be API breaking, but it would be state machine breaking, I believe. There is no need to backport it.

@crodriguezvega crodriguezvega added type: code hygiene Clean up code but without changing functionality or interfaces 29-fee good first issue Good for newcomers labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-fee good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

1 participant