Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require light clients to set client and consensus states as necessary in the Initialize function #2900

Closed
3 tasks
colin-axner opened this issue Dec 7, 2022 · 0 comments · Fixed by #2936
Closed
3 tasks

Comments

@colin-axner
Copy link
Contributor

Summary

The majority of functions in 02-client must set their own client and consensus states when updating state. The initialization function should do the same.

Proposal

  • Remove these lines of code
  • Add setting of client state to solo machine (note, the consensus state does not need to be set separately)
  • Add setting of client and consensus states in tendermint similar to how we set the metadata
  • update migration documentation
  • update client state docs added in Adding docs for client state interface #2886
  • update initialize godoc

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants