Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate or remove solo machine header sequence #2940

Closed
3 tasks
colin-axner opened this issue Dec 15, 2022 · 0 comments · Fixed by #2941
Closed
3 tasks

Deprecate or remove solo machine header sequence #2940

colin-axner opened this issue Dec 15, 2022 · 0 comments · Fixed by #2941
Assignees
@damiannolan
Labels
06-solomachine type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v7.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

As per spec changes, the solo machine header sequence is no longer required. It can be removed or deprecated. It can be removed if the change is done with v7 as it'd be apart of the breaking changes of going from v2 to v3 proto definitions for the solo machine. If the change is done after v7, it should be deprecated and addressed when we have a reason to go to v4 proto definitions for the solo machine.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added 06-solomachine type: code hygiene Clean up code but without changing functionality or interfaces labels Dec 15, 2022
@damiannolan damiannolan self-assigned this Dec 15, 2022
@damiannolan damiannolan added this to the v7.0.0 milestone Dec 15, 2022
@damiannolan damiannolan moved this to In progress in ibc-go Dec 15, 2022
@damiannolan damiannolan mentioned this issue Dec 15, 2022
Merged
9 tasks
Repository owner moved this from In progress to Todo in ibc-go Dec 19, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
06-solomachine type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
v7.0.0
Development

Successfully merging a pull request may close this issue.

chore(api)!: removing solomachine header sequence cosmos/ibc-go
2 participants
@damiannolan @colin-axner