Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up IBC Module interface #3317

Open
3 tasks
colin-axner opened this issue Mar 22, 2023 · 0 comments
Open
3 tasks

Split up IBC Module interface #3317

colin-axner opened this issue Mar 22, 2023 · 0 comments
Labels
needs discussion Issues that need discussion before they can be worked on

Comments

@colin-axner
Copy link
Contributor

Summary

Break down the IBCModule interface into 4 components:

type IBCModule interface {
    // callbacks requried to open a channel (OnChanOpenInit, OnChanOpenTry, etc)
    ChannelOpenCallbacks
    
    // callbacks required to close a channel (OnChanCloseInit, OnChanCloseConfirm)
    ChannelCloseCallbacks
    
    // callbacks required to upgrade a channel
    ChannelUpgradeCallbacks
    
    // callbacks required to complete the full packet flow
    PacketCallbacks
}

Problem Definition

ADR 8 provides callbacks to IBC actors which may only care about acting on a specific set of the callbacks, by breaking down the interface we don't require a user of these callbacks to fulfill all the function interfaces.

Proposal

see comment


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the needs discussion Issues that need discussion before they can be worked on label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Issues that need discussion before they can be worked on
Projects
Status: No status
Development

No branches or pull requests

1 participant