export util functions such as StartFlushUpgradeHandshake

[charleenfei]

is there a strong reason that we don't just want to let StartFlushUpgradeHandshake be an exported function and not need these wrappers?

To me, adding this additional level of indirection hurts my ability to reason about where things can be used in certain ways and why.

I don't think it's so bad to just export k.startFlushUpgradeHandshake .

This is a mild preference though, if the general consensus is to have this additional wrapper I'm okay with it 👍

Originally posted by @chatton in #3671 (comment)

[colin-axner]

see followup #3671 (comment)

[DimitrisJim]

I agree with Colin's approach. It is a hassle due to go's visibility rules to get these tested but the benefit of not exposing a large API outweighs that hassle.

[chatton]

I think I'm convinced by @colin-axner's response, it's not ideal but I agree it's worth doing 👍 I think we can close this issue!

[charleenfei]

closing this issue in favour of our current design