Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing gogoproto.equal option for protos #3871

Closed
2 of 3 tasks
DimitrisJim opened this issue Jun 16, 2023 · 0 comments · Fixed by #3856
Closed
2 of 3 tasks

Consider removing gogoproto.equal option for protos #3871

DimitrisJim opened this issue Jun 16, 2023 · 0 comments · Fixed by #3856
Assignees
@charleenfei
Labels
protobuf Proto file definitions and protobuf code generation

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jun 16, 2023 •
edited by charleenfei
Loading

Summary

From a small convo on #3858 (comment) (also #3856) we found out that this option is probably disabled by default making specifying it a chroe. It might be a good idea to see if we should just remote it all-together.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
protobuf Proto file definitions and protobuf code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(api)!: add missing/remove unnecessary gogoproto directive cosmos/ibc-go
2 participants
@DimitrisJim @charleenfei